Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Vehicles Fixes #4912

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Admin Vehicles Fixes #4912

merged 5 commits into from
Nov 17, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 13, 2023

About the pull request

Fixes a bunch of things with vehicles in general and for admin usage.

  • Tank couldn't collide with vehicle blockers for past 2 years due to an apparent oversight, letting it get eg. into caves. This is fixed
  • Fixed an issue with some hardpoints covering the turret of the tank and its hardpoints
  • Made the admin spawned 'tank coupon' tank properly broken for repair
  • Added an 'APC coupon' in the same vein as Tank's
  • Because Tank Coupon is a Techwebs relic and now an admin tool, it doesn't spawn VC pamphlets in ASRS anymore. Spawn them yourself!
  • Fixed a bug where bringing up a Tank via coupon as first vehicle would only give you access to APC gear in vendor.
  • Added bitfield definition for vehicle_flags

Explain why it's good for the game

I don't know if it is, but it's at least good for the admins using these

Changelog

🆑
fix: Fixed the tank driving through vehicle blockers and accessing "deep" parts of the map it wasn't intended to push.
fix: Tentatively fixed some visual bugs with turret based vehicles.
fix: Fixed using the tank coupon as first vehicle spawn causing Gear Vendor to still give out APC gear.
admin: Added an APC coupon in same vein as Tank Coupon for Admins to use.
admin: Tank/APC Coupons now spawn broken down versions of the vehicles, for the full VC experience. You want a ready to use one, just spawn it.
admin: Tank/APC coupons do not spawn VC pamphlets in ASRS anymore.
admin: Added a vehicle_flag for tanks to bypass blockers (in a legit fashion this time). Abuse at your discretion.
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Admin Make things harder for admins labels Nov 13, 2023
@harryob harryob added this pull request to the merge queue Nov 17, 2023
Merged via the queue into cmss13-devs:master with commit 97b9dd2 Nov 17, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 17, 2023
@Skatuk

This comment was marked as off-topic.

@harryob
Copy link
Member

harryob commented Nov 17, 2023

Can you fix the bug that makes the vehicle lights not work, like on the Van groundside. Its a literal pain when you go through all that work just to not be able to see in the dark, making only people with thermals or the synth being the only ones able to drive.

this pr is already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants